search

Grails-Plugin-Consortium / grails-filterpane

Filterpane plugin for grails.
Apache License 2.0
16 stars 44 forks source link

Ars 2.2.1 upgrade #3

Closed ascheffe-umd closed 11 years ago

ascheffe-umd commented 11 years ago

Upgraded the plugin to grails 2.2.1 and generated the maven pom

ctoestreich commented 11 years ago

Any status on this pull req? Need this asap as grails 2.2 bug is a blocker from using this plugin atm.

ascheffe-umd commented 11 years ago

No, no response from the owner. I just forked it and installed locally so I could use it here.

ctoestreich commented 11 years ago

thanks I might pull in your fork for now so I don't have to roll my own filtering.

skrenek commented 11 years ago

Sorry guys. I have been mired in work for the past bit. Since you are actively interested in the project, would either of you consider being added as a collaborator / co-owner of the plugin?

ctoestreich commented 11 years ago

You can add me as a collaborator and I will do a code review/merge of the pull request. What is owning one more plugin - not like I have a day job.. oh wait.

skrenek commented 11 years ago

I know what you mean. I don't work much in Grails anymore, so it has been difficult to keep thing up to date. I've been looking to add more people to the plugin for a while so it can get some love, but haven't had anyone take interest until now. Thanks for the offer. I appreciate whatever you can give.

stenix71 commented 11 years ago

Please add me as collaborator as well. I also have limited time but at least I may be able to fix some issues as I stumble upon them. This plugin is far too good to be wasted.

ascheffe-umd commented 11 years ago

The grails upgrade added them. I was 100% what for but I assumed as part of the new tag lib. They weren't excluded in the git ignore so I just went ahead and pushed them. I didn't know if thats something it auto gens on build or not.

ctoestreich commented 11 years ago

I will leave them in, but I they are going to get added to the excludes in the plugin

ctoestreich commented 11 years ago

@skrenek can you comment here and grant me publish/owner rights via grails plugin portal?

http://grails.1312388.n4.nabble.com/Grails-FilterPane-Plugin-Edit-td4643214.html

ctoestreich commented 11 years ago

@skrenek can you also transfer this plugin to the new org @grails-plugin-consortium that I created. I made you an admin for now. I am going to move over my plugins as well as I can't add travis ci hooks to collaborative ownership projects.

skrenek commented 11 years ago

@ctoestreich You're talking about transferring ownership, correct?

ctoestreich commented 11 years ago

@skrenek yep. sounds scary... super easy :) I will leave you as admin in org. You simply type the name to transfer to as "grails-plugin-consortium"

ctoestreich commented 11 years ago

I can always transfer it back if you want to 'reclaim' it.

skrenek commented 11 years ago

No worries. I just wanted to double-check that you didn't want me to fork it in the new account. I'll set it up shortly. While I am proud of the plugin, as it was my first useful open source contribution, I am more interested in seeing it live on and be useful.

skrenek commented 11 years ago

Love the Dalek gravatar, btw.

ctoestreich commented 11 years ago

:+1: