search

Grails-Plugin-Consortium / grails-filterpane

Filterpane plugin for grails.
Apache License 2.0
16 stars 44 forks source link

Cast exception #69

Open samuelecollu opened 8 years ago

samuelecollu commented 8 years ago

Hi, first of all thanks for the great work you are doing.

I'd like to report an issue that could be easily solved. When i filter on integer fields i have a cast exception. After a look to the source code i found the problem. In the class FilterPaneService, line 371 there is newValue.isInteger() ? newValue.toInteger() : null but i think should be something like this newValue = newValue.isInteger() ? newValue.toInteger() : null is the same for the other field types (double, float, bigdecimal, biginteger)

bratekarate commented 7 years ago

Fixed and created pull request https://github.com/Grails-Plugin-Consortium/grails-filterpane/pull/71

Is there anybody even working on this plugin anymore? I need to know if this will be accepted and shipped as a new version or if I have to deploy my custom artifact to my personal maven repository.

Edit: Tests have failed, but that cannot be related to my changes.

ctoestreich commented 7 years ago

I still keep an eye and release for PR. I am not actively improving this myself. The original author abandoned and I just man the releases these days instead of letting it die.

bratekarate commented 7 years ago

@ctoestreich Thanks for the fast reply. So another version will be released? Can you already give an approximate estimate when the new version will be available for use?

Andrauss commented 7 years ago

Any prevision?