search

Grails-Plugin-Consortium / grails-filterpane

Filterpane plugin for grails.
Apache License 2.0
16 stars 44 forks source link

Grails4 #84

Closed billgonemad closed 4 years ago

billgonemad commented 4 years ago

I have a branch that seems to be working with Grails 4. Note that I am unsure if these changes work in grails 3 but I am using them in my local Grails 4.0.3 project that uses this plugin. One change I was unsure of was the fact that I needed to comment out the coAuthor property on the Book domain class to get any test cases to run. All existing test cases are passing with this change.

rafapaisley commented 4 years ago

We are eager waiting for this merge !!!

ctoestreich commented 4 years ago

I am not sure if the build deploy script still work due to being idle for so long....

rafapaisley commented 4 years ago

Looks like the JDK installation is failing... You should add:

dist: trusty

To your .travis.yml file :)

ktsobal commented 4 years ago

@ctoestreich Thank you for your solution. It works! The only problem I found, was in the Methode currentCriteria in FilterPaneTagLib. There's no ".referencedDomainClass" and ".referencedPropertyType" in "domainProp". I fixed it with ".owner" and ".type". I hope this will help you. I'm excited about the next merge.