search

Grails-Plugin-Consortium / grails-jesque

1 stars 5 forks source link

cleanup of transactional and scope settings in services #12

Closed bp-FLN closed 7 years ago

bp-FLN commented 7 years ago

The transactional and scope settings are pretty outdated. In the end, all services are non-transactional by default in grails 3, so it makes no sense to have transactional field in the service. Also, the default scope for services is "singleton", so we can get rid of this field as well.

ctoestreich commented 7 years ago

I was the one who made the PR to fix the transactionality of the services, this only changed in grails 3.1.4+ to have this turned off by default. See https://github.com/grails/grails-core/issues/9785

The usage of the scope variable can definitely be removed. That was some legacy code that made it through. 👍