Grails-Plugin-Consortium / grails-jesque

1 stars 5 forks source link

Fix Exception handling in GrailsWorkerImpl #14

Closed peh closed 7 years ago

peh commented 7 years ago

GrailsWorkerImpl has never run the "removeInFlight" method in it's process method. This i causing redis to pile up "inflight" lists until at some point it will run out of memory! While "adding this back" i found the undocumented, untested and basically useless (as it is just copying the functionality of the exceptionHandler) "customJobExceptionHandler". For the above reasons I removed it and refactored the CustomWorkerListener to now also support adding a list of listeners. This way one can easily get Information about failed jobs by simply ignoring all other events coming in. I also started adding test (and documentation) for this stuff as till now there is nearly no working Tests.

ctoestreich commented 7 years ago

will try and release asap