search

Grails-Plugin-Consortium / grails-jesque

1 stars 5 forks source link

make custom worker, eventListener and throwableHandler work again #8

Closed peh closed 8 years ago

peh commented 8 years ago

with the change to .yml based configration we have to expect the custom clazzes to be defined as string. so i implemented a way to do this as strings OR classes.

i also found a severe bug in GrailsWorkerImpl which was calling jedis methods on the jedisPool instead of a ressource from within the pool.

ctoestreich commented 8 years ago

@peh Thanks. Looks like a missed that one pool change. I wasn't a huge fan of changing to a pool locally as it meant I had to pull in and change the core classes from Jesque. I have a pseudo PR (sent him my changed code) open with Greg Haines who owns the core jesque library. Using the pool is way better IMHO and to support Sentinel it was the only way given how the connection used to be created.

peh commented 8 years ago

yeah back in the grails-2 days i tried to do the same and we have been stuck with a custom flat file dependency to our own jesque & grails-jesque

thanks for merging this one can you give me a ping on slack as soon as you released it please?