search

GrailsInAction / graina2

Source code for the 2nd edition of Grails in Action
90 stars 91 forks source link

Data table had redundant column #1

Closed tomaslin closed 6 years ago

tomaslin commented 11 years ago

In your code, you have a column that is password, but this had the same value - a better approach would be to use the mechanism specified here - http://docs.spockframework.org/en/latest/data_driven_testing.html#combining-data-tables-data-pipes-and-variable-assignments and just have password as it's own field, making your test easier to read

pledbrook commented 11 years ago

Sorry, only recently noticed that there were some pull requests. I've made a note in the [Proposed Changes] wiki page, but I can't just apply the patch because the manuscript needs updating as well.