search

GrailsInAction / graina2

Source code for the 2nd edition of Grails in Action
90 stars 93 forks source link

v14 Listing 7.11 includes unused params-field #101

Open motzer opened 10 years ago

motzer commented 10 years ago

Sample code in v14, listing 7.11 sets params['profile.homepage'], but also params.with {homepage = ... }, which has no effect on the test.

pledbrook commented 10 years ago

You're right. homepage shouldn't be referenced at all based on the actual form. We should at least remove the homepage = ... from params.with(). It might make sense to remove params['profile.homepage'] as well to keep the test in sync with the HTML form and avoid any confusion. What do you think @glenasmith ?