search

GrailsInAction / graina2

Source code for the 2nd edition of Grails in Action
90 stars 92 forks source link

MEAP v10 Chap 5 Search Form #37

Open mlhart58 opened 11 years ago

mlhart58 commented 11 years ago

Are you assuming the readers of your book will know how to create the search form all on their own? What to name it, where to save it, and what the content of said file should be? All based on Figure 5.9?

If so, you should say so. And I think you maybe giving some of us more credit then we are due.

At the very least, you should point the reader to the Chapter 5 download files and AdvSearch.gsp (for those of us who expected a little more instruction on how to "generate a basic search form for Hubbub profiles". I am assuming this is what I am supposed to do.

And then where are we supposed to put the "advResults()" code that follow figure 5.9? I am still searching the download files for that code.

Did someone else write this section? It does not seem to be on par with the first 4 chapters.

Well I found the "AdvResults" code in UserController.groovy file. I still think this section needs some more work to be user friendly and instructional.

pledbrook commented 11 years ago

Thanks for the feedback. I need to do some more work on chapter 5. You're right that there are too many steps missing from this section. I may even need to reconsider using this advanced search example, since it requires two new GSPs, which take space that detract from the essence of what we're talking about. Need to think on this.