Closed marcpa00 closed 11 years ago
I've went a little further using constants from Calendar and updated the BootStrap of every chapter in https://github.com/marcpa00/graina2/commit/bbd10dc04abd4bf57bc723647734fba99b1a9e24
Can you please rebase against master and resubmit? Thanks.
Will do as soon as I figure out how to clean up my repo. I'm tempted to remove my fork on githup and re-create it from scratch, but I am afraid to impact GrailsInAction/graina2 ?
Re-forking will not affect the main repo, so go ahead. And the best way to submit patches is:
git checkout <new branch>
git rebase master
I like to do interactive rebase to squash commits like "missing from previous commit" or "minor fix" or "merge" before pushing, but it's not critical.
Great, thanks for the clear instructions ! I think I got it now. Pull request #47.
Closing this pull request as it is superceeded by #47.
For issue #44
dayOfMonth
is not a valid key for the Map passed toDate.updated()
: usedate
, could also useCalendar.DAY_OF_MONTH
.Sorry for the messy pull request, only commit 5bf49fb is relevant, rest is me-learning-github-by-making-mistakes :-)