search

GrailsInAction / graina2

Source code for the 2nd edition of Grails in Action
90 stars 92 forks source link

Clarify use of grails.project.groupId in chapter 1 example #48

Closed pledbrook closed 10 years ago

pledbrook commented 10 years ago

The "A Word on Package Naming" sidebar doesn't make it clear whether the example QOTD application is using the grails.project.groupId setting or not. For example, figure 1.8 shows the qotd package being used rather than com.grailsinaction.qotd.

Is the latter just an example suggestion? If so, then the sidebar should make this clear and point out that the default qotd is used throughout the chapter and the GitHub source code. Otherwise, the examples need updating to use com.grailsinaction.qotd.

crazysmoove commented 10 years ago

Also please note that (at least for me using Grails 2.3.0), you have to put quotes around "com.grailsinaction.qotd" -- without quotes, you don't get an error, but the setting is ignored.

pledbrook commented 10 years ago

I only noticed the missing quotes today! All sorted now.