search

GrailsInAction / graina2

Source code for the 2nd edition of Grails in Action
90 stars 92 forks source link

MEAP ch2 v12: *Minor* comments #59

Closed tikeswar closed 10 years ago

tikeswar commented 10 years ago

1. Pg. 33, Listing 2.1 Please mention the listing name as dataGenerator.groovy

2. Pg. 40 first paragraph. Spock is likely to become the default testing framework ... I think it already is in Grails 2.3.1??

3. Pg. 40 first paragraph. It reads "... in your Hubbub project, ..." But, the Hubbub project is not created/defined yet??

4. Pg. 41 Last paragraph. It reads as The order of the blocks is fixed-iven -> ... It should read as (note iven vs given) The order of the blocks is fixed-given -> ...

5. Pg. 41, Listing 2.3 for QuoteAnalyzerSpec.groovy Pg. 42, Listing 2.4 for QuoteAnalyzerSpec.groovy Pg. 43, Listing 2.5 for QuoteAnalyzer.groovy Need to add the following import? import qotd.Quote

6. A side note for Pg. 42, Listing 2.4 for QuoteAnalyzerSpec.groovy

        where:
        inputQuotes |   expected
        null        |   0
        ...

The null case fails with a NullPointerException (as expected?).

pledbrook commented 10 years ago
  1. I'm going through this chapter at the moment. I don't see a reference from the body of the chapter to dataGenerator.groovy, so why put that in the title of the listing? I'm genuinely curious and happy to do so if it helps.
  2. Yes. We have to update the whole book to Grails 2.3. Fortunately, even if Grails 2.4 comes out before book release, the 2.3 -> 2.4 changes won't affect the content.
  3. This got picked up by our tech ed. Yes, that's incorrect and should be QOTD.
  4. Thanks. That got picked up too. All I can say is that it wasn't me :smile:
  5. Technically yes, but the test should really be in the same package as the other classes anyway.
  6. Interesting. I'll check that out and either remove that data set or fix the code to handle a null input.

Thanks for the feedback!

tikeswar commented 10 years ago

Hi Peter:

  1. If the name (dataGenerator.groovy) is mentioned in the title of the listing, it would be easier to correlate the book listing with the github code (at https://github.com/GrailsInAction/graina2/tree/master/ch02/qotd). But this is only a minor thing.

Thanks for looking into it!

pledbrook commented 10 years ago

Good point. I haven't put it in the listing title, but I have mentioned its location in the paragraph immediately before the listing. That should work fine.

tikeswar commented 10 years ago

Thanks, Peter.

pledbrook commented 10 years ago

All fixed in the current manuscript.

tikeswar commented 10 years ago

Great, thank you!