search

GrailsInAction / graina2

Source code for the 2nd edition of Grails in Action
90 stars 92 forks source link

MEAP ch3 v12: *Minor* comments #60

Open tikeswar opened 10 years ago

tikeswar commented 10 years ago

I think many listings references are wrong in the text (for example please see 5, 7, and 8 below). Package info is present in some listings but missing in others.

1. Pg. 65: Types that can be used in domain classes It reads last-Updated. Should it be lastUpdated?

2. Pg. 66: Unit Versus integration tests? It reads /grails-app/test/YourArtifactTest.groovy. Should it be /grails-app/test/YourArtifactSpec.groovy?

3. Pg. 66 (last paragraph) Spock is already added by default?

4. Pg. 69 The line just above Section "3.2.3 Deleting users" I think the "()" is not needed.

5. Pg. 81 (top line) It reads, "In listing 3.8 ...". Should it be listing 3.10?

6. Pg. 83 (above listing 3.13) It reads, "which you used previously in our Profile example in listing 3.10" Did we? (Sorry, not very clear.)

7. Pg. 85 (just below Listing 3.15) It reads, "You can see the hasMany relationship in listing 3.17, ..." Should it be listing 3.15?

8. Pg. 85 (sidebar: How belongsTo affects ...) It reads, "In listing 3.18, ...". Should it be listing 3.15?

9. Pg. 86 Which class does Listing 3.17 belong to? UserIntegrationSpec.groovy, PostIntegrationSpec.groovy, or a new class TagIntegrationSpec.groovy? I think it does not matter, but what would be the best practice?

10. Pg. 87 Which class does Listing 3.18 belong to? UserIntegrationSpec.groovy?

pledbrook commented 10 years ago

Thanks for the feedback!