Open tikeswar opened 10 years ago
1. Some mention of the updated register.gsp that uses the register2 (instead of register as in the Listing 7.9, Pg. 161-162) would be helpful in the book. Also, please include the passwordRepeat in the register.gsp (https://github.com/GrailsInAction/graina2/blob/master/ch07/hubbub/grails-app/views/user/register.gsp).
register.gsp
register2
register
passwordRepeat
2. The profile action in UserController is not listed anywhere in the book (unless I missed it) until the end of Section 7.4 (Pg. 174). And without that we won't get to the expected profile page as shown in Figure 7.11 (Pg. 174). However, the online code (https://github.com/GrailsInAction/graina2/blob/master/ch07/hubbub/grails-app/controllers/com/grailsinaction/UserController.groovy) does include the profile action, and it would be helpful to include that in the book too.
profile
UserController
3. I had some issues uploading the profile photo, which turned out to be because of the constraints. In the book it just says photo nullable: true (Pg. 78), but in the online code it is photo nullable: true, maxSize: 500 * 1024 (https://github.com/GrailsInAction/graina2/blob/master/ch07/hubbub/grails-app/domain/com/grailsinaction/Profile.groovy). Specifying the maxSize constraints helps and would be nice to include it in the book.
photo nullable: true
photo nullable: true, maxSize: 500 * 1024
maxSize
Thanks for the feedback!
pledbrook
commented
10 years ago pledbrook
commented
10 years ago
1. Some mention of the updated
register.gspthat uses theregister2(instead ofregisteras in the Listing 7.9, Pg. 161-162) would be helpful in the book. Also, please include thepasswordRepeatin theregister.gsp(https://github.com/GrailsInAction/graina2/blob/master/ch07/hubbub/grails-app/views/user/register.gsp).2. The
profileaction inUserControlleris not listed anywhere in the book (unless I missed it) until the end of Section 7.4 (Pg. 174). And without that we won't get to the expected profile page as shown in Figure 7.11 (Pg. 174). However, the online code (https://github.com/GrailsInAction/graina2/blob/master/ch07/hubbub/grails-app/controllers/com/grailsinaction/UserController.groovy) does include theprofileaction, and it would be helpful to include that in the book too.3. I had some issues uploading the profile photo, which turned out to be because of the constraints. In the book it just says
photo nullable: true(Pg. 78), but in the online code it isphoto nullable: true, maxSize: 500 * 1024(https://github.com/GrailsInAction/graina2/blob/master/ch07/hubbub/grails-app/domain/com/grailsinaction/Profile.groovy). Specifying themaxSizeconstraints helps and would be nice to include it in the book.