search

GrammaTech / gtirb

Intermediate Representation for Binary analysis and transformation
https://grammatech.github.io/gtirb/
Other
305 stars 36 forks source link

Add ExitKind field to Block. #19

Closed nweston closed 5 years ago

nweston commented 5 years ago

This is a pretty straightforward change, I just wanted to get a second opinion on two things:

  1. Naming
  2. Do we have the right set of values for ExitKind?
AaronBallman commented 5 years ago
  1. None of the names are particularly worrying to me, but others may have Opinions on what color they'd like the bikeshed.
  2. Maybe? Do we want to model exceptional flow control differently than normal control flow?