search

GrammaticalFramework / gf-core

Grammatical Framework core: compiler, shell & runtimes
https://www.grammaticalframework.org
Other
129 stars 35 forks source link

Clean up Compute.ConcreteNew and TypeCheck.RConcrete #119

Closed johnjcamilleri closed 3 years ago

johnjcamilleri commented 3 years ago

Adresses #117, with one comment/question:

GF.Compile.TypeCheck.ConcreteNew - a completely new version by me which allows full type inference and supports implicit arguments. The latest is not quite complete and was therefore never activated. It does, however, type check the English RGL.

Although in GF.Compile.CheckGrammar, functions from both TypeCheck.Concrete and TypeCheck.ConcreteNew are used, so the latter is not completely unactivated either. Is this intentional, @krangelov? If so I think it's ok to leave things as they are and merge this PR.