search

GrammaticalFramework / gf-ud

Functions to analyse and manipulate dependency trees, as well as conversions between GF and dependency trees. The main use case is UD (Universal Dependencies), but the code is designed to be completely generic as for annotation scheme. This repository replaces the old gf-contrib/ud2gf code. It is also meant to be used in the 'vd' command of GF and replace the supporting code in gf-core in the future.
Other
7 stars 15 forks source link

various changes for concept alignment #4

Closed harisont closed 3 years ago

harisont commented 3 years ago

Here is a summary of the changes:

aarneranta commented 3 years ago

Thanks! If gfud still compiles with these changes, they should be OK. The new RTree module needs to be imported in several places I guess.

Aarne

From: Arianna Masciolini notifications@github.com Sent: Tuesday, March 2, 2021 4:44:11 PM To: GrammaticalFramework/gf-ud Cc: Subscribed Subject: [GrammaticalFramework/gf-ud] various changes for concept alignment (#4)

Here is a summary of the changes:

You can view, comment on, or merge this pull request online at:

https://github.com/GrammaticalFramework/gf-ud/pull/4

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GrammaticalFramework/gf-ud/pull/4, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWBQXLKAN7D4NDUIVUNMDLTBUBUXANCNFSM4YPHABZA.

harisont commented 3 years ago

Yes, it does compile and RTree is imported in the various other modules now. The only thing that you should really check before merging is

in UDConcepts, simplified prUDSentence so that sent_ids are just numbers starting from 1 (but it looks like there are good reasons to revert this?)

The numbering was different because of some requirements of the malt parser, but it was a bit peculiar, I wonder if it is still necessary to keep it that way...?

aarneranta commented 3 years ago

Does it produce different numberings in the resulting CoNLL for any input?

From: Arianna Masciolini notifications@github.com Sent: Tuesday, March 2, 2021 4:56:21 PM To: GrammaticalFramework/gf-ud Cc: Aarne Ranta; Comment Subject: Re: [GrammaticalFramework/gf-ud] various changes for concept alignment (#4)

Yes, it does compile and RTree is imported in the various other modules now. The only thing that you should really check before merging is

in UDConcepts, simplified prUDSentence so that sent_ids are just numbers starting from 1 (but it looks like there are good reasons to revert this?)

The numbering was different because of some requirements of the malt parser, but it was a bit peculiar, I wonder if it is still necessary to keep it that way...?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/GrammaticalFramework/gf-ud/pull/4#issuecomment-789011375, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWBQXMRQPF75TUPG4JXLGTTBUDCLANCNFSM4YPHABZA.

harisont commented 3 years ago

For every input, because the original numbering started from 1000001 and each id was preceded by "gfud", so gfud1000001,gfud1000002 and so on. The new one is instead 1,2...

But obviously I can switch back

aarneranta commented 3 years ago

I prefer the old numbering, because it is easier to sort by Unix tools. And also change globally, e.g. gfud1 -> gfud2 if we want to combine two treebanks.

Aarne.

From: Arianna Masciolini notifications@github.com Sent: Tuesday, March 2, 2021 5:15:15 PM To: GrammaticalFramework/gf-ud Cc: Aarne Ranta; Comment Subject: Re: [GrammaticalFramework/gf-ud] various changes for concept alignment (#4)

For every input, because the original numbering started from 1000001 and each id was preceded by "gfud", so gfud1000001,gfud1000002 and so on. The new one is instead 1,2...

But obviously I can switch back

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/GrammaticalFramework/gf-ud/pull/4#issuecomment-789024804, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWBQXJOJUCE77D2V6ERWUDTBUFJHANCNFSM4YPHABZA.

harisont commented 3 years ago

Now it is again as it was initially, I'm not sure about the other change you were mentioning

aarneranta commented 3 years ago

Numbering the sentences was the only change I needed. Everything is merged now. Thanks for your contributions!

Aarne.

From: Arianna Masciolini notifications@github.com Sent: Tuesday, March 2, 2021 5:23:41 PM To: GrammaticalFramework/gf-ud Cc: Aarne Ranta; Comment Subject: Re: [GrammaticalFramework/gf-ud] various changes for concept alignment (#4)

Now it is again as it was initially, I'm not sure about the other change you were mentioning

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/GrammaticalFramework/gf-ud/pull/4#issuecomment-789030983, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWBQXMRRPO6CS3KE4J23HTTBUGI3ANCNFSM4YPHABZA.