Grammernatzi / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
60 stars 39 forks source link

Feature Request: RDM Grand Impact options #160

Closed 0kie closed 2 months ago

0kie commented 2 months ago

Option to NOT replace verproc, verthunder II and veraero II into grand impact when you have grand impact ready and have Verproc into jolt and/or RDM AOE combo options enabled

Grand Impact ready lasts longer than Acceleration, and sometimes you may want to save grand impact for later and not use immediately, if you have procs ready you can delay grand impact's use

edit to add that is currently not possible to do the standard opener with verproc into jolt plus, because when you have grand impact ready it is replacing verthunder/veraero 3

Grammernatzi commented 2 months ago

For single Target I could easily do this but I am curious why you would want it gone for aoe? If you're using acceleration, why would you want to use veraero/thunder 2? To stack it with dual cast I guess?

0kie commented 2 months ago

Appreciate the fast response.

About the aoe option, I just realized it doesn't make sense because grand impact replaces impact anyway, so it is impossible to do accel > impact and save grand impact for later, that was my bad x_x

So just the single target option would be greatly appreciated

Grammernatzi commented 2 months ago

The reason I asked is because always having the option to use Grand Impact without having to manually drag Jolt or Impact to your bar would be nice. So if all it did was replace jolt normally on your single target, you could still access it at any time if it was always replacing your AOE. That's how I was planning to have it set up.

On Sat, Jul 6, 2024, 10:32 PM 0kie @.***> wrote:

Appreciate the fast response.

About the aoe option, I just realized it doesn't make sense because grand impact replaces impact anyway, so it is impossible to do accel > impact and save grand impact for later, that was my bad x_x

— Reply to this email directly, view it on GitHub https://github.com/Grammernatzi/XIVComboPlugin/issues/160#issuecomment-2212329059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUFLNK3EMINS3SAL7ZNUTZLDHHHAVCNFSM6AAAAABKOXVZMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGMZDSMBVHE . You are receiving this because you commented.Message ID: @.***>

0kie commented 2 months ago

Yes, it makes sense to always replace in the aoe, that was my bad forgetting it replaces impact already on vanilla. Just in single target that it becomes a problem not having access to verproc/verthunder III/veraero III because of the opener and ogcd alignment (possibility of saving grand impact for later use). So, just the option to turn it off for single target would really be needed, my initial request about the aoe one too was not well thought

Grammernatzi commented 2 months ago

Yeah, so that's what I'm doing atm. It'll always replace AoE but it will only replace what would otherwise be Jolt in Verproc into Jolt. That should give you the functionality you want.

On Sat, Jul 6, 2024 at 10:38 PM 0kie @.***> wrote:

Yes, it makes sense to always replace in the aoe, that was my bad forgetting it replaces impact already on vanilla. Just in single target that it becomes a problem not having access to verproc/verthunder III/veraero III because of the opener and ogcd alignment (possibility of saving grand impact for later use)

— Reply to this email directly, view it on GitHub https://github.com/Grammernatzi/XIVComboPlugin/issues/160#issuecomment-2212330574, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUFLP7UQR7DBHOOD5SHEDZLDH6NAVCNFSM6AAAAABKOXVZMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGMZTANJXGQ . You are receiving this because you commented.Message ID: @.***>

Grammernatzi commented 2 months ago

Done, pushing