Grammernatzi / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
61 stars 40 forks source link

Monk AoE Combo Issue #35

Closed FFXIVWytes closed 2 years ago

FFXIVWytes commented 2 years ago

Hi there,

I just noticed that the MNK AoE combo toggle doesn't seem to be updating any of the actions in the chain. Arm of the destroyer is the base aoe action (no form required) so that's what i've put on my bars and i've got both the aoe + aoe balance functions (this doesn't update for masterful blitz either) toggled but when I use arm it just gives the form but doesn't proceed to four point fury. If i put rockbreaker on my bars it doesn't change either.

Thanks for your time.

geramaia commented 2 years ago

Same here. The MNK AoE combo doesn't seem to be working. None of the actions are changing no matter which aoe combo i put onto my bar.

Grammernatzi commented 2 years ago

Rockbreaker is changing for me. Arm/Shadow of the Destroyer is not supposed to change, only Rockbreaker (and Four-Point Fury in PB), it even says this in the description. It may be a Dalamud issue if Rockbreaker is not changing, I'm not sure. Someone else was having weird issues with SMN AoE as well on Daemitus' fork. Does using a staging version fix this issue? I've not been using the stable releases, myself, though the logic should work with both.

geramaia commented 2 years ago

Yesterday seemed to work fine. And when i did some testing just now, the AoE Combo from this FFXIV Combo Very Expanded plugin, it the AoE combo changes using this. https://raw.githubusercontent.com/PrincessRTFM/MyDalamudPlugins/master/pluginmaster.json

FFXIVWytes commented 2 years ago

Can give the testing fork a go. How do I add that? A different repo?

Grammernatzi commented 2 years ago

Dalamud has its own testing branch that you can enable via config, or in-game (you have to restart, though). Here. I only recommend using it if you have to, though, of course. I also just pushed an update to revert the Four-Point Fury PB changes I made, since they weren't working, but that didn't affect the regular combo for me.

Megasder commented 2 years ago

Before it didnt work but after the newest update a few minutes ago it works again (both the rockbreaker and fpf features)

FFXIVWytes commented 2 years ago

Seems to have fixed it for me as well! Rockbreaker now updates properly!

Grammernatzi commented 2 years ago

Huh, very odd. Perhaps trying to tie it to gauge bugged it earlier? It didn't for me, though; perhaps because I was using the staging version of Dalamud. I'll just keep as it is, for now, at least.