Canonicalize all width types to size_t, all widths to bit widths.

Granary / granary2

Dynamic binary translation framework for instrumenting x86-64 user space Linux programs

MIT License

39 stars 5 forks source link

Canonicalize all width types to size_t, all widths to bit widths. #71

Closed pgoodman closed 9 years ago

pgoodman commented 10 years ago

I think a coding smell is the mix between bit and byte widths, and the use of int for client-facing code, and uint16_t for arch-specific code. I think canonicalizing all client-facing code to size_t is better, then the signedness issues go away, and then canonicalizing all input/output widths of functions/methods to be bit widths.

pgoodman commented 9 years ago

Done in branch data_reactor_wip.