Granary / granary2

Dynamic binary translation framework for instrumenting x86-64 user space Linux programs
MIT License
39 stars 5 forks source link

Canonicalize on StartAppPC or DecodedPC, but not both. #78

Open pgoodman opened 9 years ago

pgoodman commented 9 years ago

DecodedBasicBlock uses StartAppPC, but has no associated EndAppPC. It also has a StartCachePC, but having an end is meaningless due to fragment scheduling.

NativeInstruction uses DecodedPC and DecodedLength. This could equivalently be represented with bounding PCs, using StartAppPC and EndAppPC.

I think we should canonicalize on these two function names across blocks and instructions.

It's also worth thinking about if Start or Begin is the right prefix.