search

Granary / granary2

Dynamic binary translation framework for instrumenting x86-64 user space Linux programs
MIT License
39 stars 5 forks source link

Remove CacheMetaData::start_pc #85

Closed pgoodman closed 9 years ago

pgoodman commented 9 years ago

For the time being, code in the cache does not get invalidated. Recent changes to how cached code is indexed will also mean that only trace entrypoints will go into the code cache index. Because of this, I think that the CacheMetaData::start_pc field can be removed and somehow stored separately in the Index data structure.

pgoodman commented 9 years ago

This is going to require adjusting AssignBlockCacheLocations and FindBlockEntrypointFragments.

pgoodman commented 9 years ago

Actually this is a really bad idea. I briefly tried it.