search

GrandMoff100 / RegexFactory

Dynamically construct regex patterns with native python representations
https://regexfactory.readthedocs.io
GNU General Public License v3.0
7 stars 4 forks source link

Use proper typing #4

Closed ItsDrike closed 2 years ago

ItsDrike commented 2 years ago

Follow PEP 484 and add type hints to all functions in the code-base. These type-hints are currently compatible with both mypy and pyright.

Now that the code-base is compatible with these, you should consider also integrating them into the automated CI/CD github workflows. (If you don't know how to, let me know if you want them added)

Note: I've renamed ormore attribute for Amount class to a more pythonic or_more name and I've also changed the parameter names for Range class from a and z to start and stop

GrandMoff100 commented 2 years ago

Later today I'll implement pyright into a CI/CD workflow that'll run along the same triggers as the flake8 workflow.

GrandMoff100 commented 2 years ago

Are there any more changes that you are intending to make before merging this?