search

GrandOrgue / GoOdf

A tool for creating/editing organ definition files for GrandOrgue
GNU General Public License v3.0
11 stars 1 forks source link

Setters not working #20

Closed William-Purvis closed 1 year ago

William-Purvis commented 1 year ago

Having given up trying to get Divisionals working I am trying to use SetterXXXDivisonalYYY in my ODF. When I create a new one in GOODF it always comes up as Setter000Divisional000, and lacks positional info. I edit the PositionX and PositionY into the ODF but GOODF just discards it.

William-Purvis commented 1 year ago

Just spotted the Divisional and Combination fields! Apologies

William-Purvis commented 1 year ago

Re-opening: My comment about losing positional information is still a problem. Setting PositionX and PositionY in GOODF is ignored, and if I add them in to the ODF afterwards, they do get loaded and appear in the GUI, but are again discarded on saving.

Just load and save is enough to loose them.

larspalo commented 1 year ago

Do you remember to tab out of the PositionX and PositionY spinctrls? Are you using a recent GOODF version?

William-Purvis commented 1 year ago

Yes, version=0.5.0

William-Purvis commented 1 year ago

Propose a fix: GUIDivisional: 44,47d43 < if (m_positionX != -1) < outFile->AddLine(wxT("PositionX=") + wxString::Format(wxT("%i"), m_positionX)); < if (m_positionY != -1) < outFile->AddLine(wxT("PositionY=") + wxString::Format(wxT("%i"), m_positionY));

Seems to work for me.

larspalo commented 1 year ago

@William-Purvis Yes, that's a good catch, thanks! I forgot to add those lines for the GUIDivisional. I've committed the fix now!