the off switch side remains there and cannot be removed
Yes, that's indeed a bug that needs fixing. The question is just how to best do that? One possibility, which I'm leaning towards, is to detach the image/mask on and image/mask off operations completely so that they are totally independent from each other. (Even in GO I don't think that there is any enforcing of having them both customized, it's perfectly possible to use the builtin bitmaps for just one of the states - but the bitmap size of off must match what is used for on). Another possibility is to empty both fields if the image on is emptied, either directly without asking or after another question dialog asking if that is what the user desires and if so check that the off image will match the default on image size (and if it doesn't just remove it too). In any way, the handling of on and off states need to be separated.
I think a good option is to allow direct text entry and deletion.
I don't. It's opening a can of worms! User input can frequently be wrong, not to mention that it can easily lead to portability problems as the windows file system is case-insensitive so a faulty entry could work on windows while it will not on any case sensitive system. Therefore it's best to only allow the paths to be filled in by selection from the actual file system and never by hand. The files need to exist and have a full path exactly as they are named, not only for GOODF but more importantly for GO, which means that no faulty user input is acceptable at all.
Yes, that's indeed a bug that needs fixing. The question is just how to best do that? One possibility, which I'm leaning towards, is to detach the image/mask on and image/mask off operations completely so that they are totally independent from each other. (Even in GO I don't think that there is any enforcing of having them both customized, it's perfectly possible to use the builtin bitmaps for just one of the states - but the bitmap size of off must match what is used for on). Another possibility is to empty both fields if the image on is emptied, either directly without asking or after another question dialog asking if that is what the user desires and if so check that the off image will match the default on image size (and if it doesn't just remove it too). In any way, the handling of on and off states need to be separated.
I don't. It's opening a can of worms! User input can frequently be wrong, not to mention that it can easily lead to portability problems as the windows file system is case-insensitive so a faulty entry could work on windows while it will not on any case sensitive system. Therefore it's best to only allow the paths to be filled in by selection from the actual file system and never by hand. The files need to exist and have a full path exactly as they are named, not only for GOODF but more importantly for GO, which means that no faulty user input is acceptable at all.
Originally posted by @larspalo in https://github.com/larspalo/GOODF/discussions/35#discussioncomment-6650501