GrandOrgue / GoOdf

A tool for creating/editing organ definition files for GrandOrgue
GNU General Public License v3.0
11 stars 1 forks source link

wxSpinCtrlDouble precision and increment #50

Closed larspalo closed 1 year ago

larspalo commented 1 year ago

Do we really need these to go up by 0.000001 step at a time?

Wouldn't it make more sense to go in whole numbers rather than 10 e-6 fractions?

Originally posted by @Bumblebee001 in https://github.com/larspalo/GOODF/discussions/45

larspalo commented 1 year ago

Perhaps there might be a way to keep floating point precision and anyway make the increments in whole steps. The wxSpinCtrlDouble is intially created with 0.000001 increment in the constructor, then afterwards calling:

    wxSpinCtrlDouble->SetDigits(6);
    wxSpinCtrlDouble->SetIncrement(1.0f);

seem to allow both decimals entry and also increment by whole steps. Needs testing before implementation!

larspalo commented 1 year ago

Should be fixed with d2f4279f46a9ab60be0d1b551bc9cf89dc1525a3.

Bumblebee001 commented 1 year ago

Ok, thanks. Much obliged for seeing the worth of my observations.

On Sun, 13 Aug 2023 at 13:49, larspalo @.***> wrote:

Should be fixed with d2f4279 https://github.com/larspalo/GOODF/commit/d2f4279f46a9ab60be0d1b551bc9cf89dc1525a3 .

— Reply to this email directly, view it on GitHub https://github.com/larspalo/GOODF/issues/50#issuecomment-1676334665, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVM7NV5QRLFB3RMEV54NCDXVC5MZANCNFSM6AAAAAA3LHZEHQ . You are receiving this because you were mentioned.Message ID: @.***>

larspalo commented 1 year ago

@Bumblebee001 With the 0.7.2 release this should have been addressed. Do you think this issue is fixed?

Bumblebee001 commented 1 year ago

I haven’t tried yet

On Wed, 23 Aug 2023 at 22:36, larspalo @.***> wrote:

@Bumblebee001 https://github.com/Bumblebee001 With the 0.7.2 release this should have been addressed. Do you think this issue is fixed?

— Reply to this email directly, view it on GitHub https://github.com/larspalo/GOODF/issues/50#issuecomment-1690602656, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVM7NXRXIBYH4G3BUFZBU3XWZSUFANCNFSM6AAAAAA3LHZEHQ . You are receiving this because you were mentioned.Message ID: @.***>

Bumblebee001 commented 1 year ago

Yes - that makes a lot more sense. Thanks.