search

GrandOrgue / GoOdf

A tool for creating/editing organ definition files for GrandOrgue
GNU General Public License v3.0
11 stars 1 forks source link

Testing image loading for Gui elements #8

Closed davidgritter closed 1 year ago

davidgritter commented 1 year ago

When testing the ability to load custom images for GUI elements by clicking the browse button, i can find, for example .bmp images, but not .BMP images, often used in hauptwerk organ definitions (case is not important in Windows search) Can the browse be made case insensitive?

larspalo commented 1 year ago

Yes, I did that for the Gui Manual panel. There's no simple way to make the wildcard case insensitive for the wxfiledialog (on both wxGTK and to still be cross platform), but one can overload them to give that impression. For the Gui Manual I added .bmp, .BMP and *.Bmp versions (for all supported file types), do you think that's enough for all image loading elements?

larspalo commented 1 year ago

Test the latest commit and see if that's good enough.

davidgritter commented 1 year ago

seems to be ok to me. I have seen .bmp , .BMP, .wav, .WAV in the same organ packages several times and this version picks up both.

larspalo commented 1 year ago

Ok, then I close this issue for now.