GrandOrgue / GoOdf

A tool for creating/editing organ definition files for GrandOrgue
GNU General Public License v3.0
11 stars 1 forks source link

Crash on macOS writing minimal odf #92

Closed MStraeten closed 4 months ago

MStraeten commented 4 months ago

I'm creating a minimum odf via:

  1. set organ paramters
  2. add manual, rename, set number of keys 32
  3. --> Write ODF file is ok: Test.organ.txt
  4. add a new stop, rename, set number of keys 32
  5. --> Write ODF --> crash
Process 30695 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x6c)
    frame #0: 0x000000010008eba8 GoOdf`Windchestgroup::getIsPercussive(this=0x0000000000000000) at Windchestgroup.cpp:251:9
   248  }
   249
   250  bool Windchestgroup::getIsPercussive() {
-> 251      return m_isPercussive;
   252  }
   253
   254  void Windchestgroup::setIsPercussive(bool percussive) {
Target 0: (GoOdf) stopped.
(lldb)

Version 0.10.0 was fine

larspalo commented 4 months ago

Thanks for reporting. Crash was caused because there is no windchestgroup that can be accessed but the rank/stop is trying anyway. Will be fixed in 0.11.1 soon.

larspalo commented 4 months ago

Issue should be fixed with https://github.com/GrandOrgue/GoOdf/releases/tag/v0.11.1.

MStraeten commented 4 months ago

Fix confirmed, thanks