search

GrandOrgue / OdfEdit

A tool for GrandOrgue ODF edition, and Hauptwerk to GrandOrgue ODF conversion.
GNU General Public License v3.0
9 stars 1 forks source link

v2.5beta1 #26

Closed eturpault closed 1 year ago

eturpault commented 1 year ago

Addition of object drag&drop Management of Ctrl+a and past in text editor (needed for Linux) Some improvements in HW2GO convertion

rousseldenis commented 1 year ago

Great to see this PR!

To improve a little bit the history of changes here, it's better to have an explicit message in commits (other than 'v2.5beta1' - and you can have more than one commit in one PR).

That will help review or if people (or even you) want to search for a change backwards, easier to find it.

Here is an example of what is done on grandorgue :

image

eturpault commented 1 year ago

Yes I try to improve my pratice of GitHub :wink: I put comments in my commits, but indeed it would be better to put a short description text in the commit's name.

rousseldenis commented 1 year ago

Yes I try to improve my pratice of GitHub wink I put comments in my commits, but indeed it would be better to put a short description text in the commit's name.

Yes. What I wanted to say, it's better too to have small bunches of changes in one separate commit (and having much commits is not bad) to better identify those changes. That can help explaining the process of changes.

Nevertheless, this is great !