search

GrandOrgue / OdfEdit

A tool for GrandOrgue ODF edition, and Hauptwerk to GrandOrgue ODF conversion.
GNU General Public License v3.0
7 stars 1 forks source link

Feature request: Set MIDIInputNumber for Manuals and Enclosures #39

Closed larspalo closed 9 months ago

larspalo commented 9 months ago

It would be nice if the MIDIInputNumber was set for converted manuals and (real) enclosures (not the ones used for voicing adjustments).

For the manuals the MIDIInputNumber=1 is used for indicating the pedal, MIDIInputNumber=2 is the lowest manual, MIDIInputNumber=3 the next and so on.

For enclosures (real swell boxes) the numbering should also start with MIDIInputNumber=1 for the leftmost swell pedal and increment for each next.

eturpault commented 9 months ago

Ok I will add it in OdfEdit v2.9, thanks @larspalo for the proposal. For enclosures, in the HW ODF syntax there is none attribute permitting to know the position of the swell pedals on the organ console, if there are several enclosures I can try to find their physical order to sorting them according to the order of their PositionX + PositionY value. What do you think ?

larspalo commented 9 months ago

if there are several enclosures I can try to find their physical order to sorting them according to the order of their PositionX + PositionY value

Yes, that would certainly work. I don't know anything about the HW "standard" layout if it even exists, but for GO it would usually be enough to look at what ends up on the main panel.

eturpault commented 9 months ago

This is what I implemented and can be tested with the binary shared here : https://github.com/GrandOrgue/OdfEdit/issues/28#issuecomment-1902812659 I tested it with the Sonus Paradisi Billerbeck sample set which has 3 swell pedals (defined in two secondary panels), it works well.

For my knowledge, in which cases this value MIDIInputNumber is usefull ?

larspalo commented 9 months ago

For my knowledge, in which cases this value MIDIInputNumber is useful

In the File->Settings... dialog you have the Initial MIDI tab. There you can pre-configure what keyboards you want to have connected to pedal, first manual and some other things like enclosures and a few setter elements. If the correct MIDIInputNumber is set in the sample set it makes organ configuration somewhat quicker for new organs that you open/load as it will respect your initial MIDI configuration. Many things likely still need further manual configuration, but it's nice when the on-screen keyboards just respond to the correct console keyboard immediately... I've just recently realized the importance of the MIDIInputNumber myself, even though it's been around for quite a long time!

eturpault commented 9 months ago

Implemented in OdfEdit v2.9