search

GrandOrgue / OdfEdit

A tool for GrandOrgue ODF edition, and Hauptwerk to GrandOrgue ODF conversion.
GNU General Public License v3.0
9 stars 1 forks source link

OdfEdit freezes when converting the BIS Romsey demo #44

Closed pgwid-og closed 8 months ago

pgwid-og commented 9 months ago

Let me start saying thank you for sharing this wonderful tool here on GitHub. I wish I could have made use of this years ago when I struggled preparing my first custom ODFs, using Excel-Spreadsheets (though it was good fun, too!).

One of the HW-ODF I tried to convert the BIS Romsey demo (https://www.beautyinsound.co.uk/products/romsey-abbey-demo-free). OdfEdit-v2.9 just freezes (no error message shown) when building a coupler, cf. grafik

As a work-around I deleted the couplers in the HW-ODF, so I could convert it into a GO-ODF, but you might want to investigate this issue yourself.

P.S. In case others would like to have a look at the BIS Romsey demo: The samples don't have pitch information provided. So one couldn't alter the temperament in GO. Some pictures are not in the correct format to be used by GO. Besides that it is a nice little English organ (and we don't have too many of them yet in GO).

eturpault commented 9 months ago

Thanks for this report, there is certainly an error in Python when executing the conversion SW with these couplers, I will look at it and do a fix.

eturpault commented 9 months ago

I found the reason of the issue : a variable used but not defined before, basic error... It was caused by 12 couplers which are defined in the HW ODF without having associated image defined, so they cannot be controlled. It will be fixed in next OdfEdit version. There was an issue in OdfEdit caused by missing images for a volume slider (which uses Hauptwerk embedded standard images), it will be fixed in next OdfEdit version. Strangely the keys of the keyboards and the pedal are all transparent images, so one cannot see the keys moving on the console. Here is the ODF generated after the fixes described above : BIS Organs - Romsey Abbey Demo.zip

Thank you for your kind words about OdfEdit, it encourages me to continue to improve it. I'm glad people are using it.

pgwid-og commented 9 months ago

Lovely, thank you for your quick response. I tried your Romsey-ODF on my computer and (besides those warnings) it nearly worked perfect (I just ha to replace the "..\SilentLoop.wav" (which are missing) through "DUMMY"!

eturpault commented 9 months ago

OdfEdit automatically adds the file SilentLoop.wav in the root folder of the sample set (where are the folders OrganDefinition and OrganInstallationPackages) when doing the HW to GO conversion. You can recover it here and place it manually at the root folder of this sample set. Replacing it by DUMMY in the ODF you are losing the keys release and stops disengage noises.

eturpault commented 8 months ago

Fixed in OdfEdit v2.10. In addition the extended notes at the upper part of the keyboards are correctly retuned with v2.10.