Deleting a rank does not renumber existing ranks

GrandOrgue / OdfEdit

A tool for GrandOrgue ODF edition, and Hauptwerk to GrandOrgue ODF conversion.

GNU General Public License v3.0

9 stars 1 forks source link

Deleting a rank does not renumber existing ranks #47

Closed oleg68 closed 8 months ago

oleg68 commented 9 months ago

After I deleted an (invalid) rank Rank084 (see #46) I receive an error Missing required value section 'Rank084' entry 'FirstMidiNoteNumber

I expected that all ranks with higher numbers would be renumbered N -> N-1 and all references to them would be updated.

eturpault commented 9 months ago

The automatic ranks renumbering after the deletion of one section is not implemented today in OdfEdit, I can add it. This would have to be done for the following types of sections :

Enclosure, General, Panel, PanelElement, PanelImage, Rank, Switch, Tremulant, WindchestGroup,

and note done for the following :

Coupler, Divisional, DivisionalCoupler, Manual, Stop

Do you agree ?

oleg68 commented 9 months ago

Do you agree ?

Yes, I do.

eturpault commented 8 months ago

Implemented in OdfEdit v2.10.

eturpault commented 8 months ago

@oleg68 please let me know if it works as you expected. Other good idea to improve OdfEdit features are welcome from you, thanks.

oleg68 commented 8 months ago

@eturpault Yes, it does. Thank you.