search

GrandOrgue / OdfEdit

A tool for GrandOrgue ODF edition, and Hauptwerk to GrandOrgue ODF conversion.
GNU General Public License v3.0
7 stars 1 forks source link

Cannot convert HW organ with v2.12 #57

Closed kerkovits closed 4 months ago

kerkovits commented 4 months ago

When converting HW to GO, Switch999 objects do not have mandatory attribute DefaultToEngaged.

eturpault commented 4 months ago

In OdfEdit v2.12 I have made a modification in link with the issue https://github.com/GrandOrgue/grandorgue/issues/1874, in order to define the attribute DefaultToEngaged only when a Drawstop has not the attribute Function or has Function=Input. If it has an input switch, the state of a Drawstop after loading is set by the initial state of its input switch(es), so DefaultToEngaged is useless. I have seen that it is implemented in this way in GrandOrgue. With this way to do there is no error when loading the ODF in GrandOrgue (even if it is described as required in the help which should be changed as I suggested in the issue 1874).

I see that I have not implemented it correctly, DefaultToEngaged=Y is set but DefaultToEngaged=N is not set, and unfortunately I have not seen this big issue during my validation tests before to release the v2.12... I will fix it in the next version of OdfEdit to come soon, once I have completed the conversion of tremmed samples of the Piotr Graboswki sample sets. Thanks for the report.

kerkovits commented 4 months ago

Am I right that the problem is line 7665?

eturpault commented 4 months ago

Yes you are perfectly right. If you add the following two lines in line 7667 it will solve the issue :

            else:
                GO_switch_dic['DefaultToEngaged'] = 'N'

In line 7618 the following lines have to be added as well :

                    else:
                        GO_object_dic['DefaultToEngaged'] = 'N'
kerkovits commented 4 months ago

Thank you. I have another issue right now.