search

GrandOrgue / OdfEdit

A tool for GrandOrgue ODF edition, and Hauptwerk to GrandOrgue ODF conversion.
GNU General Public License v3.0
7 stars 1 forks source link

Problem with the last key of manual, if it is a sharp key #58

Closed kerkovits closed 4 months ago

kerkovits commented 4 months ago

After converting this organ:

https://drive.google.com/file/d/1kETnsTcDM19Lnw15aB0b6GsELzdaDJsp/view

I have to add manually the following lines to Panel000Element001: ImageOff_LastDis=..\OrganInstallationPackages\002204\images\keys\Up-Sharp.bmp ImageOn_LastDis=..\OrganInstallationPackages\002204\images\keys\Down-Sharp.bmp

eturpault commented 4 months ago

Indeed currently OdfEdit manages only the following last key notes : A, C, D, F, G You can see this management in lines 6427 to 6442 in OdfEdit.py v2.12.

In the next version I will extend this management to all notes (both first and last keys).

eturpault commented 4 months ago

I have tested my implementation with this Gelence sample set, it works well. It will be present in OdfEdit v2.13. Thank you for having raised this interesting use case.

eturpault commented 4 months ago

It is fixed in OdfEdit v2.13.