BUG: off value in send for "ON" button no longer overrides the off value in send for organ stops.

[David-Poole]

Hello,

I use Novation Launchpads for stop control and set velocity numbers for the off and on values in the send dialog. Since the recent updates, the off value for the "ON" button in Master Controls no longer overrides the off value for the organ stops in any of the samplesets I use, however, it does override the off values for my Generals, G.C. and SET pistons. When I change samplesets or shut down G.O., all my stops are still lit up. Please fix this, it makes it really challenging when switching samplesets to have to double launch them.

David

[David-Poole]

This photo is with GO launched.

This photo is after I shut down GO

On the right launchpad, the pads that went out were my SET, G.C. and General Presets. As you can see, all my stops are still lit up with their default note-off values. Please note that in the first picture, there's no engaged stops or general presets.

I hope this helps explain my problem. I wish I could help with the code base, but the only language I have any real experience with is python.

[oleg68]

@David-Poole I cann't understand what does override mean.

Do you want that MIDI OFF messages would be sent for all stops that were engaged when the user closes an organ?

[David-Poole]

What I mean is that when shutting down GO or switching samplesets that if there's MIDI send events set for the "ON" button, that the off and on values for the velocity take precedence over the velocity values for the stops and other MIDI controls. For example, let's say I have set send and receive information for an 8' Diapason for MIDI number 11 on channel 1 for my Novation Launchpad. For the SEND I have velocity number 15 for the off value and velocity number 13 for the on value. For the "ON" button I have in the SEND 9x-NOTE OFF and the velocity for note off set to 0. Currently, GrandOrgue is only taking the values I have set for the stops and is ignoring what I have set for the "ON" button when I shutdown GO or switch samplesets.Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: Oleg Samarin @.> Sent: Sunday, July 2, 2023 8:48:52 a.m. To: GrandOrgue/grandorgue @.> Cc: David Poole @.>; Mention @.> Subject: Re: [GrandOrgue/grandorgue] BUG: off value in send for "ON" button no longer overrides the off value in send for organ stops. (Issue #1555)

@David-Poolehttps://github.com/David-Poole I cann't understand what does override mean.

Do you want that MIDI OFF messages would be sent for all stops that were engaged when the user closes an organ?

— Reply to this email directly, view it on GitHubhttps://github.com/GrandOrgue/grandorgue/issues/1555#issuecomment-1616638856, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT6ZKXNNAB2FGMGJJ6U6UDLXOFU3DANCNFSM6AAAAAAYSCYJQE. You are receiving this because you were mentioned.Message ID: @.***>

[oleg68]

@David-Poole

Could you post here the screenshots of Midi Event Settings (both Receive and Send pages) for one stop (ex. 8' Diapason) and for the ON button in the master control?

[David-Poole]

Attached are the photos of my MIDI settings. As you can see, for the stop, I have a non zero off value. That's to assign a dimmer version of the colour I assigned for that stop, and the number in the on value is a brighter version of the same color. As you can see I have assigned a velocity number of 0 for the off value of the on button sent to the same MIDI number but for all devices. I have tried isolating for the device in question and the problem still persists. Get Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: Oleg Samarin @.> Sent: Monday, July 3, 2023 2:31:03 PM To: GrandOrgue/grandorgue @.> Cc: David Poole @.>; Mention @.> Subject: Re: [GrandOrgue/grandorgue] BUG: off value in send for "ON" button no longer overrides the off value in send for organ stops. (Issue #1555)

@David-Poolehttps://github.com/David-Poole

Could you post here the screenshots of Midi Event Settings (both Receive and Send pages) for one stop (ex. 8' Diapason) and for the ON button in the master control.

— Reply to this email directly, view it on GitHubhttps://github.com/GrandOrgue/grandorgue/issues/1555#issuecomment-1618984487, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT6ZKXIRLTTSBSFUNJHYLKLXOMFWPANCNFSM6AAAAAAYSCYJQE. You are receiving this because you were mentioned.Message ID: @.***>

[oleg68]

Attached are the photos of my MIDI settings.

I can not see any files attached.

[David-Poole]

[David-Poole]

Sorry about that, I didn't realize they wouldn't get posted by responding via email. I hope these are sufficient.

[oleg68]

I reproduced this issue with your settings. When you close the organ, GrandOrgue sends both MIDI messages independently

22:35:06.005  Ch  0, Note Off  33
22:35:06.006  Ch  0, Note On  33, Vel  15

in an unpredictable order, so you launchpad may discard Note On 33, Vel 15 with Note Off 33 if it comes later.

I suggest not to use the same note number (33) for ON and for any stops. I'd set up your launchpad to use different midi notes for different stops and a separate note for the ON button.

It is not a GrandOrgue issue, because it sends all messages you have set up and GrandOrgue can not predict how your launchpad resolves the conflicting midi messages. You are responsible for correct midi setting.

[David-Poole]

I find that interesting. When I produced this video https://youtu.be/0_EV_7JA-fE back in March, I never had this issue at all. Everything was fine up until version 3.12. Ever since version 3.12, I've been having this issue.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: Oleg Samarin @.> Sent: Monday, July 3, 2023 3:49:02 PM To: GrandOrgue/grandorgue @.> Cc: David Poole @.>; Mention @.> Subject: Re: [GrandOrgue/grandorgue] BUG: off value in send for "ON" button no longer overrides the off value in send for organ stops. (Issue #1555)

I reproduced this issue with your settings. When you close the organ, GrandOrgue sends both MIDI messages independently

22:35:06.005 Ch 0, Note Off 33 22:35:06.006 Ch 0, Note On 33, Vel 15

in an unpredictable order, so you launchpad may discard Note On 33, Vel 15 with Note Off 33 if it comes later.

I suggest not to use the same note number (33) for ON and for any stops. I'd set up your launchpad to use different midi notes for different stops and a separate note for the ON button.

It is not a GrandOrgue issue, because it sends all messages you have set up and GrandOrgue can not predict how your launchpad resolves the conflicting midi messages. You are responsible for correct midi setting.

— Reply to this email directly, view it on GitHubhttps://github.com/GrandOrgue/grandorgue/issues/1555#issuecomment-1619063943, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT6ZKXL2SMBRBW73CLQQXJLXOMO25ANCNFSM6AAAAAAYSCYJQE. You are receiving this because you were mentioned.Message ID: @.***>

[oleg68]

@David-Poole The order of sending midi messages for different buttons is not documented and it may be changed from one version to another.

So make your midi setting working regardless the message order.

When a midi receiver receives several Note messages with the same MIDI note number, it usually discards all messages except the last one. So use separate midi note numbers for different buttons.