GrandOrgue / grandorgue

GrandOrgue software
Other
158 stars 40 forks source link

Overhaul of the Midi recorder functionality #1629

Open rnditdev opened 1 year ago

rnditdev commented 1 year ago

Hello,

In order to enhance the MIDI recording functionality from a connected MIDI keyboard, I'd want to suggest the following improvements to the MIDI recorder:

1) Ability to play the last MIDI recording in memory without storing it in a file

2) Create MIDI file slots, 8 could suffice, saved with standard names, like 1.mid, etc, and create buttons to store and choose those, if existent, similar to how combinations work.

This would make easier to implement midi recording functionality in organs without screens.

Thanks.

larspalo commented 1 year ago

@oleg68 What if we would make the same kind of file navigations for MIDI recordings on the panel as has been done with the combinations in the setter? The MIDI recordings of GO are quite tightly tied to a specific organ which would make it sensible to actually store the recordings under that organ just like with the combinations.

If we also would integrate the recorder functionality better with the MIDI player, we could push the just recorded MIDI (file) there first (maybe instead of saving it, which of course that would mean we need a separate option button to actually save the file). Also having options to load any file (and the possibility to navigate between current MIDI recordings) in the panel instead of having to go to the menu option first could be a significant improvement in my opinion.

Currently we don't even see what file is actually loaded, nor is the recording/player panel updated when a MIDI file is selected from Audio/Midi->Load MIDI (it still say no file, even though it's now possible to push the play button and get the file to play back).

oleg68 commented 1 year ago

The main difference between the sequencer and the midi recoder is that the sequencer is mostly used for loading existing combination from a file or for modifying it. When the user wants to export to the new combination file, he/she still needs to use the main application menu.

Otherwise, the midi recorder is mostly used for creating a new midi file. So it does not allow to use a similar midi-oriented UI for it.

Of cause, we may enchance the midi recorder/player UI. Feel free to propose your ideas. We need to think a lot before choosing and implementing one.

rnditdev commented 1 year ago

What about just implementing playing the last recorded sequence with a button? This could cover a huge percentage of the daily grind: Record, listen, critique, record again, and so on. You already have the notes in memory, you just need a trigger to play them. Thanks!

briff commented 7 months ago

What about just implementing playing the last recorded sequence with a button? This could cover a huge percentage of the daily grind: Record, listen, critique, record again, and so on. You already have the notes in memory, you just need a trigger to play them. Thanks!

I had the same idea. Mostly I use recording during practice sessions.