search

GrandOrgue / grandorgue

GrandOrgue software
Other
150 stars 39 forks source link

Feature Request: Add tremulant parameters to the GUI #1659

Open ahall41 opened 9 months ago

ahall41 commented 9 months ago

It might be useful to be able to change the tremulant paremeters via a settings dialog. Maybe an option to switch off loading sampled tremulants (like another piece of software can do) to save memory. And maybe an option to try an experimental implementation, when available.

larspalo commented 9 months ago

It might be useful to be able to change the tremulant paremeters via a settings dialog

That would introduce a conflict of interest between sample set producers and users. A better option would be to have built in tremulant options for each division (just like built in divisionals) in GO that could be user modified. The ones supplied by the sample set producer for a specific organ should really not be user edited.

Maybe an option to switch off loading sampled tremulants

Depending on how this was done in the organ it might already be possible. A separate rank (like OdfEdit produces) can easily be set to "Don't load" in the Organ Settings.

ahall41 commented 9 months ago

My problem is that, when transforming HW XML to GO .organ, the tremulant information is in (several) .wav files, so all I can do is use some default value ... which it would be nice for the user to change easily (they can change it in any case by editing the ODF?).

Using IsTremulant gives a smoother switchover, avoids an extra rank and (ATM) having to code Pipe001=...BlankLoop.wav?

The tremulants operate on Windchests, so probably ought to be in the Organ Settings dialogue. A flag in the ODF for the tremulant could decide whether the parameters can be changed.

eturpault commented 9 months ago

OdfEdit has a menu option permitting to enable or disable the conversion from HW ODF to GO ODF of the wave based tremulants. One day OdfEdit will not place anymore the tremmed samples in a separate rank when I will have implemented it, as suggested by @larspalo in this issue https://github.com/GrandOrgue/OdfEdit/issues/33.

ahall41 commented 9 months ago

But ... Lars has just advocated using 2nd ranks, to avoid loading tremmed samples. [BTW @eturpault - where you have only partially sampled tremulants, such as Chorzow, you will still need separate ranks ... leave it in as an option!]