search

GrandOrgue / grandorgue

GrandOrgue software
Other
166 stars 40 forks source link

Added capability of control buttons with Control Change MIDI events with different keys but same values using "Bx Ctrl Change Fixed On Value Toggle" and "Bx Ctrl Change Fixed Off Value Toggle" https://github.com/GrandOrgue/grandorgue/issues/1392 #1667

Closed oleg68 closed 1 year ago

oleg68 commented 1 year ago

Resolves: #1392

This PR

  1. Fixed matching midi events with Bx Ctrl Change Fixed On Value Toggle and Bx Ctrl Change Fixed Off Value Toggle event patterns. Earlier they trigger drowstops between ON and OFF. Now the first event only switches the drawstop ON and the second one switches to OFF. The events are ignored if the drawstop is already in the ON (OFF) state.
  2. If ON and OFF ctrl change events have different keys and the same values, now Detect for complex MIDI setup creates two event patterns with Bx Ctrl Change Fixed On Value Toggle and Bx Ctrl Change Fixed Off Value Toggle
oleg68 commented 1 year ago

@rousseldenis could you approve this PR?