search

GrandOrgue / grandorgue

GrandOrgue software
Other
150 stars 39 forks source link

Proper EnglishUse #1716

Closed Bumblebee001 closed 7 months ago

Bumblebee001 commented 8 months ago

Hi Oleg,

Avoid ”cann’t” as it is not used in English. If anything it is “can’t” with one “n”.

In writing we use “cannot” in full. This is true for other words like isn’t (is not), shouldn’t (should not) and so on. Avoid abbreviations when writing especially in help files and dialogue boxes.

Mark

rousseldenis commented 8 months ago

@Bumblebee001 thanks for this. Are you able to propose a PR with correct strings? Thanks

Bumblebee001 commented 8 months ago

Im not sure I understand your reply fully.

On Fri, 10 Nov 2023 at 11:20, Denis Roussel (ACSONE) < @.***> wrote:

@Bumblebee001 https://github.com/Bumblebee001 thanks for this. Are you able to propose a PR with correct strings? Thanks

— Reply to this email directly, view it on GitHub https://github.com/GrandOrgue/grandorgue/issues/1716#issuecomment-1805457485, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVM7NVPRTRMOTAITJ4VMGDYDX5VJAVCNFSM6AAAAAA7F5EZQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGQ2TONBYGU . You are receiving this because you were mentioned.Message ID: @.***>

Bumblebee001 commented 8 months ago

Should be: “I’m” and since this is a “chat” it will be acceptable.

On Fri, 10 Nov 2023 at 11:21, Mark Bugeja @.***> wrote:

Im not sure I understand your reply fully.

On Fri, 10 Nov 2023 at 11:20, Denis Roussel (ACSONE) < @.***> wrote:

@Bumblebee001 https://github.com/Bumblebee001 thanks for this. Are you able to propose a PR with correct strings? Thanks

— Reply to this email directly, view it on GitHub https://github.com/GrandOrgue/grandorgue/issues/1716#issuecomment-1805457485, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVM7NVPRTRMOTAITJ4VMGDYDX5VJAVCNFSM6AAAAAA7F5EZQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGQ2TONBYGU . You are receiving this because you were mentioned.Message ID: @.***>

rousseldenis commented 8 months ago

@Bumblebee001 I wanted to say, if you want to contribute and change existing strings, you can propose a Pull Request here in order to correct terms. GrandOrgue is open to everyone that want to contribute.

Bumblebee001 commented 8 months ago

I do participate already.

I’ve been using GO ever since it was created more than a decade ago and I have been producing sample sets for it too (Maltese Historic Pipe Organs). 😉

On Fri, 10 Nov 2023 at 11:29, Denis Roussel (ACSONE) < @.***> wrote:

@Bumblebee001 https://github.com/Bumblebee001 I wanted to say, if you want to contribute and change existing strings, you can propose a Pull Request here in order to correct terms. GrandOrgue is open to everyone that want to contribute.

— Reply to this email directly, view it on GitHub https://github.com/GrandOrgue/grandorgue/issues/1716#issuecomment-1805470401, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVM7NUEYJ247ATONTEKZ43YDX6YLAVCNFSM6AAAAAA7F5EZQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGQ3TANBQGE . You are receiving this because you were mentioned.Message ID: @.***>

oleg68 commented 8 months ago

@Bumblebee001 Having searched the GrandOrgue source code I found several occurences of can not but I couldn't find any cann't. Where did you see them?