GrandOrgue / grandorgue

GrandOrgue software
Other
149 stars 39 forks source link

Mishandling of mutex #1738

Closed d-musique closed 7 months ago

d-musique commented 7 months ago

Hi, there exists an instance of GOMutexLocker which is not properly kept in the scope, thus having no effect. While I know nothing of deeper implicitations, it's most definitely an anomaly.

https://github.com/GrandOrgue/grandorgue/blob/9b9995829f27f7011cddf62b6d7eaa3d4b8ff4ac/src/grandorgue/sound/GOSound.cpp#L353C7-L353C62

The warning is from clang-tidy which says: Object destroyed immediately after creation; did you mean to name the object?