search

GrandOrgue / grandorgue

GrandOrgue software
Other
149 stars 39 forks source link

Fixed crash with rtaudio/asio https://github.com/GrandOrgue/grandorgue/issues/1772 #1788

Closed oleg68 closed 5 months ago

oleg68 commented 5 months ago

This PR fixed a RtAudio bug of incompatibility with thr latest Asio SDK that caused a crash #1772

larspalo commented 5 months ago

@oleg68 Have you submitted the RtAudio fix upstream?

oleg68 commented 5 months ago

@oleg68 Have you submitted the RtAudio fix upstream?

No, I haven't. Because RtAudio ships with it's own clone of asio sdk and they avoided this bug by modifying the asio code.

I don't like this way because

In case the Licensed Software Developer Kit is modified, it shall not be published, sold or distributed without agreement of Steinberg

So I fixed this bug by modifying RtAudio instead of ASIO. Modyfying RtAudio is not prohibited by it's license:

including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software

So I wanted to submit the fix upstream, at first I would need to ask the Rt maintainer to remove the asio clone. I'm not ready to do this now.