Changed types of GOPipeConfig members - Githubissues

GrandOrgue / grandorgue

GrandOrgue software

Other

148 stars 40 forks source link

Changed types of GOPipeConfig members #1795

Closed oleg68 closed 4 months ago

oleg68 commented 5 months ago

This PR

Replaces the unsigned and int types of members of GOPipeConfig with shorter types: uint16_t, int8_t and GOBool3
Changes return types of the GetEffectiveXXX methods of GOPipeConfigNode
Renames GOPipeConfigNode::GetEffectiveFloatSum to GetEffectiveSum and makes it polymorthic
Extractes a common code from GOPipeConfigNode::GetEffectiveXXX methods to the new methods GetEffectiveUint8 and GetEffectiveBool

It is just refactoring. No GO behavior should be changed.

oleg68 commented 4 months ago

@larspalo @rousseldenis could you approve this PR?