Added capability of loading only GUI panels without audio samples by specifying the "-g" switch from the command line https://github.com/GrandOrgue/grandorgue/issues/1602

GrandOrgue / grandorgue

GrandOrgue software

Other

148 stars 40 forks source link

Added capability of loading only GUI panels without audio samples by specifying the "-g" switch from the command line https://github.com/GrandOrgue/grandorgue/issues/1602 #1797

Closed oleg68 closed 4 months ago

oleg68 commented 4 months ago

Resolves: #1602

This PR

Reworks parsing the command line
Implements the -h (--help) option that displays all possible command line options
Implements the -g (--gui-only) option that disables loading sound samples

oleg68 commented 4 months ago

@larspalo @rousseldenis may be introducing a commond line option -c ConfigFileName for altering a config file instead of -g would be better?

larspalo commented 4 months ago

may be introducing a commond line option -c ConfigFileName for altering a config file instead of -g would be better?

No, I think you can leave the -g as a "just-gui" option.

Specifying a -c configFile, or a -p presetNumber is certainly viable and could be relevant, but both should perhaps be part of another PR? Or do you want to expand upon this PR?

rousseldenis commented 4 months ago

@larspalo @rousseldenis may be introducing a commond line option -c ConfigFileName for altering a config file instead of -g would be better?

As @larspalo said, -g should be sufficent at this moment. Maybe, indeed, a specific config file could be an improvement.

oleg68 commented 4 months ago

No, I think you can leave the -g as a "just-gui" option.

Then could you approve this PR?

Specifying a -c configFile, or a -p presetNumber is certainly viable and could be relevant, but both should perhaps be part of another PR? Or do you want to expand upon this PR?

No, I don't. It will be a future enchancement.