search

GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 40 forks source link

Added support of "Couple Through" mode of Virtual Couplers https://github.com/GrandOrgue/grandorgue/issues/1657 #1810

Closed oleg68 closed 4 months ago

oleg68 commented 4 months ago

Resolves: #1657

This PR enables using recursive coupling for all virtual couplers as discussed in #1657

larspalo commented 4 months ago

@oleg68 Seems to be working as intended, but I noticed that the "Couple Through" option is not triggering immediately. It's necessary to re-strike the key for it to take effect both for activation and de-activation. It's perhaps a minor thing and not many would even think anything about it, as normally you'd set the option once for an organ and then forget about it, but I think it would be a nicer behaviour if the couple through action would activate/de-activate immediately even on held keys.

larspalo commented 4 months ago

@oleg68 Yes, the typo is fixed. Now, what about the other issue I mentioned? The couple through mechanism is not activated/de-activated immediately when pushed (one has to re-strike the key for it to take effect). A nicer behaviour would be that it acted upon existing key presses immediately - it's a bit like what you mentioned in #1813 for the enclosure with zero minimum amplitude.

oleg68 commented 4 months ago

@larspalo I will try to fix it later.

oleg68 commented 4 months ago

@larspalo I implemented refreshing the key states when changing Couple Through during a key is pressed