Rewrote GOSelectOrganDialog with the GOSimpleDialog

GrandOrgue / grandorgue

GrandOrgue software

Other

148 stars 40 forks source link

Rewrote GOSelectOrganDialog with the GOSimpleDialog #1832

Closed oleg68 closed 3 months ago

oleg68 commented 3 months ago

This is a preparatory PR for the next commit for #1663

This PR reimplementing the Organ Selection dialog with GOSelectOrganDialog.

As a result

it receives the right icon
it's position and size are stored
it receives the Help button

oleg68 commented 3 months ago

@rousseldenis @larspalo could you take a look here?

This is the last intermediate change that blocks submitting the final PR for #1663

larspalo commented 3 months ago

@oleg68 Ok, the loading dialog size is remembered now, which is good. But the user selected width of the columns are not. It would be better to have a more dynamic layout that expand to fit available width instead of the absolute column widths currently used.

oleg68 commented 3 months ago

@larspalo I'm planning to implement saving the column sizes in a future PR (for both this dialog and Settings/Organs). This PR only replaces the diagog class and does nothing with the internal elements.

Do you agree that GO behavior has not become worse with this PR? If yes, please approve this PR for I could submit a next enchancement.

oleg68 commented 3 months ago

@rousseldenis could your approve this pr?