search

GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 40 forks source link

size limit for images in GO #1840

Closed pgwid-og closed 3 months ago

pgwid-og commented 3 months ago

Yesterday I tried to convert a new sample set (http://www.pipeloops.com//product_info.php?products_id=64) to GO. It uses bitmaps with the size 5760 x 3336, which is obviously too large for GO (afaik the max size is 4000). Since HD pictures are much bigger than the ones in old days, it might be the time to enlarge the upper limit for image sizes? It is a bit annoying to rescale the images and calculate all the position parameters in the ODF again, although Lars' GoODF helps a bit with this job. Oliver

larspalo commented 3 months ago

If I remember correctly, the limit of the image size comes actually from the limit of the panel size.

larspalo commented 3 months ago

The size limit is imposed in GOConfigReader::ReadSize funcion. So to change it it's necessary to alter the file src/core/config/GOConfigReader.cpp line 544:

if (100 <= size && size <= 4000)

which is a no-brainer.

Given 8K UHD a raise to 8000 would currently be enough, but there are even higher resolutions available so 16000 or greater isn't out of the question. ;-)

oleg68 commented 3 months ago

I would increase it to 30000

larspalo commented 3 months ago

@oleg68 Then it should be 32000 to match the 4K increases that seems to be current screen resolution development.

oleg68 commented 3 months ago

@oleg68 Then it should be 32000 to match the 4K increases that seems to be current screen resolution development.

OK

pgwid-og commented 3 months ago

Thank you for the quick solution. I am looking forward to Version 3.14.