search

GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 40 forks source link

Wave tremulant on/off affects pipes that should not be affected. #1855

Closed larspalo closed 2 months ago

larspalo commented 3 months ago

Currently due to a bug, likely in the crossfading/new attacking re-work of the audio engine, a wave based tremulant will affect a default sample (IsTremulant=-1) that should not be affected by the wave-based tremulant on the same windchestgroup by triggering a new attacking/fading. Both odfs in the tremulant demo sample set linked below shows this. For instance in the IsTremulantDemo.organ one can activate the Plain stop, hold down a key and activate/de-activate the Wave tremulant (that should not affect the Plain stop at all (it has a default value of IsTremulant=-1) and hear the effect of the bug.

TremulantDemo.zip

This sample set assumes GO v3.14.0, an earlier version needs the Percussive=N value added to the ranks.

oleg68 commented 3 months ago

@larspalo I tried to fix this bug. Could you test https://github.com/oleg68/GrandOrgue-official/actions/runs/8544025323 ?

larspalo commented 2 months ago

@oleg68 Yes, this seems to work now as it should.

oleg68 commented 2 months ago

Thank you, @larspalo . Then could you approve two renaming PRs, beause this fix is based on them?