Closed oleg68 closed 7 months ago
@larspalo @rousseldenis could you approve this pr?
why the tremulants earlier were read into a negative sampler group id... Was it something about the detached releases?
Tremulant groups are negatve. Windchest groups are positive. The detached release is zero.
The reason was to store all of them in a single variable.
@larspalo could you also approve #1858
@oleg68 I'm trying to catch up! I've been away on a tour with the choir I'm leading so I've been unable to go through the PRs since some time...
@rousseldenis could you approve this PR?
Having started working on #1855, I am very difficulted to understand, how the tremulant state is stored because it is encoded to vmembers named
Sampler Group Id
.But there is another usage of the same name: sometimes a windchest number is also encoded to a member with the similar name
Sample Group Id
. Sometimes the windchest number starts with 0, sometimes - with 1.This PR brings some order into the naming. It
This is just renaming and a small refactoring of GOSoundEngine. No GO behavior should be changed.