Fixed behavior of "Detect complex MIDI setup" with Note events in different cases https://github.com/GrandOrgue/grandorgue/issues/1762

GrandOrgue / grandorgue

GrandOrgue software

Other

148 stars 39 forks source link

Fixed behavior of "Detect complex MIDI setup" with Note events in different cases https://github.com/GrandOrgue/grandorgue/issues/1762 #1884

Closed oleg68 closed 2 months ago

oleg68 commented 2 months ago

Resolves: #1762

This is the second (and the last) PR related to #1762

It fixes behavior of "Detect complex MIDI setup"

for a manual now the lowest value is detected as 1 instead of 0, that was preventing sound to stopp when the kewy was released
for a button - introduces the new events: 9x Note Fixed On and 9x Note Fixed Off, that allow to use different notes for ON and OFF

larspalo commented 2 months ago

Just remember that a valid note off message is also the Note On message with velocity 0. That case needs to be handled too in the note off category.

oleg68 commented 2 months ago

Just remember that a valid note off message is also the Note On message with velocity 0. That case needs to be handled too in the note off category.

It is already supported. 9x Note Fixed Off means not exactly Note Off, but any note event (eighter Note On or Note Off) that switches the button OFF.

larspalo commented 2 months ago

It is already supported. 9x Note Fixed Off means not exactly Note Off, but any note event (eighter Note On or Note Off) that switches the button OFF.

Good!

oleg68 commented 2 months ago

@larspalo @rousseldenis could you approve this PR?

oleg68 commented 2 months ago

@rousseldenis Pourriez-vous approuver ce PR?