search

GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 39 forks source link

RtAudio submodule using a commit that is orphan (not on any branch) #1888

Open hfiguiere opened 2 months ago

hfiguiere commented 2 months ago

RtAudio submodule using a commit that is orphan (not on any branch)

image

This cause the flatpak build to fail.

fatal: Fetched in submodule path 'submodules/RtAudio', but it did not contain 6e962c0422b5953c82466ecf07765c471a7bfacb. Direct fetching of that commit failed.
hfiguiere commented 2 months ago

If this commit is on a fork, then the submodule should point to that fork.

kerkovits commented 2 months ago

See also https://github.com/GrandOrgue/grandorgue/pull/1788

kerkovits commented 2 months ago

The patch provided affects only Windows, so for Linux, you should build against the official release.

hfiguiere commented 2 months ago

There is no source package, and the github generated one exclude submodules. So it's pulled from the git tag, and that's where the submodule bug is.

kerkovits commented 2 months ago

There is no source package?

I successfully build GO for Linux using http://www.music.mcgill.ca/~gary/rtaudio/release/rtaudio-6.0.1.tar.gz https://github.com/GrandOrgue/grandorgue/archive/refs/tags/3.14.1-1.tar.gz

hfiguiere commented 2 months ago

for GrandOrgue. This is GrandOrgue issue tracker, isn't it?

kerkovits commented 2 months ago

The second link is the GO source package. Use that, and copy the contents of the rtaudio source into submodules.

kerkovits commented 2 months ago

Or alternatively, https://github.com/GrandOrgue/grandorgue/releases/download/3.14.1-1/grandorgue-wx32-3.14.1-1.src.rpm contains all sources in the submodule directory.